Revert "Don't hard-code essential files in copy_doc_dir"#1329
Merged
Conversation
This meant we stopped copying *all* JS and CSS files, which was
incorrect. Possibly there's a better way to do this, but this fixes the
immediate problem that search is broken.
Here's an example build which is broken because of the change to
`copy_doc_dir`:
```
> aws s3 ls s3://rust-docs-rs/rustdoc/tokio-eventfd/0.2.0/
PRE i686-unknown-linux-gnu/
PRE implementors/
PRE src/
PRE tokio_eventfd/
PRE x86_64-apple-darwin/
2021-03-23 14:25:56 9 .lock
2021-03-23 14:25:56 1691 settings.html
```
Member
Author
|
I expect this to fix #1328, but haven't tested it yet. |
Member
Author
|
(The diff looks big, but it's a line-for-line revert of 6f4477b.) |
Nemo157
approved these changes
Mar 23, 2021
Member
Author
Oh weird, it does not. Looking into that now. This does fix search being broken though. |
This was referenced Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This meant we stopped copying all JS and CSS files, which was
incorrect. Possibly there's a better way to do this, but this fixes the
immediate problem that search is broken.
Here's an example build which is broken because of the change to
copy_doc_dir:Re-opens #294.
r? @Nemo157